-
Notifications
You must be signed in to change notification settings - Fork 639
Add nightly SNAPSHOT release to GitHub Packages #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add nightly SNAPSHOT release to GitHub Packages #950
Conversation
Thank you @krisbanas , will take a look. |
Hi @chrjohn, did you find a moment to have a look? |
Hi @krisbanas , no unfortunately not. Totally swamped in regular work work. :-/ |
Hi @krisbanas , thanks for your work. 👍 Please go ahead with the mentioned documentation. |
Thanks for the feedback. I added the documentation - please have a look! |
Just a quick question: we need to be compatible to JDK8. Why does the build use JDK17? Was this intentional? |
I checked and the created files are compatible with JDK8. I chose JDK17 as this is the most recent version that's used in the CI pipeline, I didn't give it much though :) Should I change it to Java 21? |
set mvnw parameters similar to normal build
Yes, please do. |
And can/should we also put the github repo here: Lines 606 to 615 in bf6a39c
The sonatype snapshot repo is not useful for our purpose since we can only upload one snapshot with the same version. |
Fixes #769
I came across the discussions under #941 and the issue #769 and had a look at the snapshot releases.
Results
3.0.0-SNAPSHOT
and keeps them timestamped under the hood.--refresh-dependencies
).Questions/Issues
altDeploymentRepository
flag (see documentation here) to override the repositories defined inpom.xml
instead of editing the file itself. The snapshot repo can instead be adjusted in the POM file..asc
) files are missing in the Packages../mvnw deploy...
command in the snapshot release pipeline likely misses some parameters.Let me know what you think.