-
Notifications
You must be signed in to change notification settings - Fork 174
Remove CONFIG_BIGNUM, always enable BigInt #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I once built a small project which didn't need it (njk here in GH) just to brag about the size of the resulting executable :-P I'd say yeah let's enable it always and remove some ifdef dance. I also have never used the extensions either. |
For completeness sake: quickjs implements bignum math in terms of https://github.com/tc39/proposal-operator-overloading but that's another abandoned proposal that I would like to remove. Standard features only. (I'm willing to make an exception for Error.prepareStackTrace. That's implemented by at least one other engine.) I'm going to tackle this in steps because it's quite a big change, likely > 10k lines deleted. The end goal is to keep only BigInt and remove libbf. That should also get the executable size down again. :-) |
Sounds like a plan! |
Part of quickjs-ng#17
Part of quickjs-ng#17
Part of quickjs-ng#17
Awesome progress! All that's missing now is to remove operator overloading and then the the whole ifdef-ing, right? |
Yep, that's right. I hope to get around to that either tonight or tomorrow. |
BigInt is part of the spec and IMO should always be enabled.
I personally don't care much for BigFloat1 or BigDecimal2 and prefer removing them unless there are really compelling reasons to keep them around.
1 non-standard
2 based on a dead stage 1 proposal: https://github.com/tc39/proposal-decimal
The text was updated successfully, but these errors were encountered: