Determinism of the engine

[angrymouse]

Hey! Can quickjs/quickjs-ng act as deterministic sandbox? (So that same code will always give same result with same input, even if code authors try to get different results). Assume that only deterministic and fully synchronous functions are exposed. Is there any way maliciously constructed code can produce non-deterministic result?

[saghul]

I guess the answer is "yes", since one can use Math.random for instance...

[bnoordhuis]

You can monkey-patch Math.random (and the Date constructor, Date.now, etc.) before you start executing code.

I wrote a PoC for V8 a few years ago and, as long as you're not dealing with external resources like files or network connections, it's relatively straightforward.

A gotcha I ran into back then was numerical stability of things like Math.atanh on different systems. V8 at the time called out to libc (like quickjs still does) and different libcs have different precision at the edges, sometimes wildly different.

[angrymouse]

Let's say I removed all of Math module (and Date and others that could introduce non-determinism).
Can non-determinism still happen with things like float multiplication/division or something like that?

[bnoordhuis]

If you restrict yourself to a single system (os/arch/etc.), I think the answer is 'no'. I can't come up with any counterexamples, at least.

Across systems? Depends on how you define non-determinism.

There can be small observable differences, like the value of Number.MIN_VALUE on systems that don't support subnormals/denormals:

In the IEEE 754-2019 double precision binary representation, the smallest possible value is a denormalized number.

If an implementation does not support denormalized values, the value of Number.MIN_VALUE must be the smallest non-zero positive value that can actually be represented by the implementation.

(from section 21.1.2.9 of the ecmascript specification)

[angrymouse]

Thank you! That answers my question well.

[juancampa]

There's at least another source of non-determinism that I discovered recently. Shapes hash values are initialized with the value of a pointer: https://github.com/quickjs-ng/quickjs/blob/229b07b9b2c811eaf84db209a1d6f9e2a8a7b0d9/quickjs.c#L4234

On most platforms, pointer values are non-deterministic. One exception is WebAssembly, where linear memory always starts at address 0x0.

[bnoordhuis]

That's not observable from JS though (or shouldn't be.)

[Lohann]

Just for the fact that this library uses the hardware for compute IEEE-754 float, and all numbers in javascript are IEEE-754 float, this is already a non-determinism factor:
https://gafferongames.com/post/floating_point_determinism/

for one reason or another it is considered very difficult to get exactly the same result from floating point calculations on two different machines. People even report different results on the same machine from run to run, and between debug and release builds. Other folks say that AMDs give different results to Intel machines, and that SSE results are different from x87.

[angrymouse]

Reopening due to issues mentioned above

[Lohann]

I haven't tested using quickjs because I don't have the dev tools in my two machines, but:

For discover the platform endianness:

let uInt32 = new Uint32Array([0x11223344]);
let uInt8 = new Uint8Array(uInt32.buffer);
 
if (uInt8[0] === 0x44) {
    console.log('Little Endian');
} else if (uInt8[0] === 0x11) {
    console.log('Big Endian');
} else {
    console.log('unknown endianness!');
}

The following code get different result between arm, x86 etc..

let nan = new Float32Array([0.0, 1.0, NaN, 0.0]);
nan[1] = nan[1] / nan[3];
nan[0] = nan[0] / nan[3];
nan[3] = nan[0] / nan[0];
let uint8 = new Uint8Array(nan.buffer);
console.log(Array.from(uint8));
// apple silicon: [0, 0, 192, 127, 0, 0, 128, 127, 0, 0, 192, 127, 0, 0, 192, 127]
// amd x86_64:    [0, 0, 192, 255, 0, 0, 128, 127, 0, 0, 192, 127, 0, 0, 192, 255]

[chqrlie]

I haven't tested using quickjs because I don't have the dev tools in my two machines, but:

For discover the platform endianness:

let uInt32 = new Uint32Array([0x11223344]);
let uInt8 = new Uint8Array(uInt32.buffer);
 
if (uInt8[0] === 0x44) {
    console.log('Little Endian');
} else if (uInt8[0] === 0x11) {
    console.log('Big Endian');
} else {
    console.log('unknown endianness!');
}

This is a feature IMHO.

The following code get different result between arm, x86 etc..

let nan = new Float32Array([0.0 / 0.0, NaN, 0.0, 0.0]);
nan[2] /= nan[1];
nan[3] /= nan[0];
let uint8 = new Uint8Array(nan.buffer);
console.log(Array.from(uint8));
// apple silicon: [0, 0, 192, 127, 0, 0, 192, 127, 0, 0, 192, 127, 0, 0, 192, 127]
// amd x86_64:    [0, 0, 192, 255, 0, 0, 192, 127, 0, 0, 192, 127, 0, 0, 192, 255]

Interesting! Testing for nans for every numeric operation seems wasteful though. How does v8 handle this?

[saghul]

I think the requirements for their use case deviate from a "traditional" JS engine.

Endinanness might not be a problem if you are always deploying on the usual suspect architectures, the float stuff looks like a different story.

I suppose that one way around both is to run QuickJS compiled to WASM. That way these 2 elements would be deterministic, as determined by the underlying WASM engine, right?

[Lohann]

That way these 2 elements would be deterministic, as determined by the underlying WASM engine, right?

Nope, just the endianness as wasm enforce Little Endian, but wasm doesn't guarantee float determinism across different architectures:
https://github.com/WebAssembly/design/blob/master/Rationale.md#nan-bit-pattern-nondeterminism