-
Notifications
You must be signed in to change notification settings - Fork 174
Commit 48e4c63a breaks tcc build #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There was no definition of the macro for compilers that were not gcc, clang or msvc. While it would be easy to add one, a better approach is to switch to memcpy() and avoid type punning altogether. Fixes: quickjs-ng#270
There was no definition of the macro for compilers that were not gcc, clang or msvc. While it would be easy to add one, a better approach is to switch to memcpy() and avoid type punning altogether. Fixes: #270
I can look into adding tcc to the Ci. |
I thought about that too but I couldn't decide on what version to target. I use https://repo.or.cz/w/tinycc.git but they don't do releases, whereas Fabrice's last release (and the version in apt) is from 2017 and lags behind quite a bit. |
Perhaps we could simply pin a commit from that repo, to make builds consistent / reproducible? |
Yes, that's a good idea. FWIW, I'm at commit |
There was no definition of the macro for compilers that were not gcc, clang or msvc. While it would be easy to add one, a better approach is to switch to memcpy() and avoid type punning altogether. Fixes: quickjs-ng/quickjs#270
At commit 48e4c63:
Previous commit builds fine.
The text was updated successfully, but these errors were encountered: