Skip to content

Commit 48e4c63a breaks tcc build #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bnoordhuis opened this issue Feb 18, 2024 · 4 comments · Fixed by #271
Closed

Commit 48e4c63a breaks tcc build #270

bnoordhuis opened this issue Feb 18, 2024 · 4 comments · Fixed by #271
Labels
bug Something isn't working

Comments

@bnoordhuis
Copy link
Contributor

At commit 48e4c63:

In file included from run-test262.c:38:
cutils.h:239: error: incompatible types for redefinition of 'PACK'

Previous commit builds fine.
@bnoordhuis bnoordhuis added the bug Something isn't working label Feb 18, 2024
bnoordhuis added a commit to bnoordhuis/quickjs that referenced this issue Feb 18, 2024
@bnoordhuis
Fix tcc build, remove PACK macro
9a59703 
There was no definition of the macro for compilers that were not gcc,
clang or msvc. While it would be easy to add one, a better approach is
to switch to memcpy() and avoid type punning altogether.

Fixes: quickjs-ng#270
@bnoordhuis bnoordhuis mentioned this issue Feb 18, 2024
Merged
bnoordhuis added a commit that referenced this issue Feb 18, 2024
@bnoordhuis
Fix tcc build, remove PACK macro (#271)
56d6002 
There was no definition of the macro for compilers that were not gcc,
clang or msvc. While it would be easy to add one, a better approach is
to switch to memcpy() and avoid type punning altogether.

Fixes: #270
@saghul
Copy link
Contributor

saghul commented Feb 18, 2024 •
edited
Loading

I can look into adding tcc to the Ci.

@bnoordhuis
Copy link
Contributor Author

I thought about that too but I couldn't decide on what version to target.

I use https://repo.or.cz/w/tinycc.git but they don't do releases, whereas Fabrice's last release (and the version in apt) is from 2017 and lags behind quite a bit.

@saghul
Copy link
Contributor

saghul commented Feb 18, 2024

Perhaps we could simply pin a commit from that repo, to make builds consistent / reproducible?

@bnoordhuis
Copy link
Contributor Author

bnoordhuis commented Feb 18, 2024 •
edited
Loading

Yes, that's a good idea. FWIW, I'm at commit 81a32ec305ee871d8129978bf3d57bc108bec46b from December and it seems to work okay. Not saying you should use it but, if you want a data point, now you have one. :-)

bluesky950520 pushed a commit to bluesky950520/quickjs that referenced this issue Mar 14, 2025
@bnoordhuis
Fix tcc build, remove PACK macro (#271)
6ac4730 
There was no definition of the macro for compilers that were not gcc,
clang or msvc. While it would be easy to add one, a better approach is
to switch to memcpy() and avoid type punning altogether.

Fixes: quickjs-ng/quickjs#270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tcc build, remove PACK macro bnoordhuis/quickjs
2 participants
@bnoordhuis @saghul