Skip to content

Add setInterval? #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
theoparis opened this issue Feb 20, 2024 · 1 comment · Fixed by #338
Closed

Add setInterval? #279

theoparis opened this issue Feb 20, 2024 · 1 comment · Fixed by #338
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@theoparis
Copy link

See bellard/quickjs#186 (comment)
It'd be nice to add setInterval to go along with the existing setTimeout function in quickjs-libc.c.
@saghul
Copy link
Contributor

saghul commented Feb 20, 2024

Not opposed to it, are to send a PR?

@saghul saghul added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 9, 2024
bnoordhuis added a commit to bnoordhuis/quickjs that referenced this issue Mar 29, 2024
@bnoordhuis
Implement setInterval()
892d532 
Coincidentally fixes a timer ordering bug for which a regression test
has been added.

Fixes: quickjs-ng#279
@bnoordhuis bnoordhuis mentioned this issue Mar 29, 2024
Merged
bnoordhuis added a commit that referenced this issue Mar 30, 2024
@bnoordhuis
Implement setInterval() (#338)
f80a5b0 
Coincidentally fixes a timer ordering bug for which a regression test
has been added.

Fixes: #279
bluesky950520 pushed a commit to bluesky950520/quickjs that referenced this issue Mar 14, 2025
@bnoordhuis
Implement setInterval() (#338)
efe6e93 
Coincidentally fixes a timer ordering bug for which a regression test
has been added.

Fixes: quickjs-ng/quickjs#279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement setInterval() bnoordhuis/quickjs
2 participants
@saghul @theoparis