Skip to content

[Feature Request] Add JS_ToBigUint64() function #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TooTallNate opened this issue Apr 12, 2024 · 3 comments · Fixed by #416
Closed

[Feature Request] Add JS_ToBigUint64() function #376

TooTallNate opened this issue Apr 12, 2024 · 3 comments · Fixed by #416
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TooTallNate
Copy link
Contributor

There already exists:

  • JS_ToBigInt64()
  • JS_NewBigUint64()
  • JS_NewBigInt64()

Notably missing from this list is JS_ToBigUint64(), which means I have to cast my uint64_t * value to int64_t * when using the JS_ToBigInt64() function. Would be nice to not need to do the casting part, and makes sense to add it for API symmetry IMO.
@saghul
Copy link
Contributor

saghul commented Apr 12, 2024

Makes sense!

@bnoordhuis bnoordhuis added enhancement New feature or request good first issue Good for newcomers labels Apr 12, 2024
@bnoordhuis
Copy link
Contributor

For anyone wanting to work on this: it should be as easy as replacing bf_get_int64 with bf_get_uint64

@saghul
Copy link
Contributor

saghul commented Apr 16, 2024

We don't assign issues, feel free to send a PR though!

saghul added a commit that referenced this issue May 27, 2024
@saghul
Add JS_ToBigUint64
8d46deb 
Fixes: #376
@saghul saghul mentioned this issue May 27, 2024
Merged
saghul added a commit that referenced this issue Jun 4, 2024
@saghul
Add JS_ToBigUint64
5b7158c 
Fixes: #376
saghul added a commit that referenced this issue Jun 4, 2024
@saghul
Add JS_ToBigUint64
e5673a8 
Fixes: #376
bluesky950520 pushed a commit to bluesky950520/quickjs that referenced this issue Mar 14, 2025
@saghul
Add JS_ToBigUint64
f1be961 
Fixes: quickjs-ng/quickjs#376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add JS_ToBigUint64 quickjs-ng/quickjs
3 participants
@TooTallNate @bnoordhuis @saghul