Skip to content

Namespace stdlib modules? #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saghul opened this issue Oct 23, 2024 · 1 comment · Fixed by #618
Closed

Namespace stdlib modules? #616

saghul opened this issue Oct 23, 2024 · 1 comment · Fixed by #618

Comments

@saghul
Copy link
Contributor

saghul commented Oct 23, 2024

I was thinking "qjs:xxx" sounds about right.

I think backwards compatibility can be easy to add (with a warning to let others know) in the module name normalizer but before I get my hands dirty I thought I'd ask.
@bnoordhuis
Copy link
Contributor

SGTM

saghul added a commit that referenced this issue Oct 24, 2024
@saghul
Prefix stdlib modules with "qjs:"
ec224aa 
Fixes: #616
@saghul saghul mentioned this issue Oct 24, 2024
Merged
saghul added a commit that referenced this issue Oct 24, 2024
@saghul
Prefix stdlib modules with "qjs:"
a157ed2 
Fixes: #616
@saghul saghul closed this as completed in cc11a82 Oct 24, 2024
bluesky950520 pushed a commit to bluesky950520/quickjs that referenced this issue Mar 14, 2025
@saghul
Prefix stdlib modules with "qjs:"
c0fc75e 
Fixes: quickjs-ng/quickjs#616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefix stdlib modules with "qjs:" quickjs-ng/quickjs
2 participants
@bnoordhuis @saghul