Skip to content

WeakRef.deref() should return undefined if value is garbage collected #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ammarahm-ed opened this issue Nov 6, 2024 · 0 comments · Fixed by #653
Closed

WeakRef.deref() should return undefined if value is garbage collected #651

ammarahm-ed opened this issue Nov 6, 2024 · 0 comments · Fixed by #653

Comments

@ammarahm-ed
Copy link
Contributor

As of now, calling deref or a garabage collected value throws an error instead of returning undefined value.

For reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakRef/deref
@ammarahm-ed ammarahm-ed mentioned this issue Nov 6, 2024
Closed
bnoordhuis added a commit to bnoordhuis/quickjs that referenced this issue Nov 6, 2024
@bnoordhuis
Fix exception in WeakRef.prototype.deref
5961708 
Set the object's opaque to a sentinel value instead of NULL, to stop
JS_GetOpaque2 from raising an "illegal class" exception.

Fixes: quickjs-ng#651
@bnoordhuis bnoordhuis mentioned this issue Nov 6, 2024
Merged
bluesky950520 pushed a commit to bluesky950520/quickjs that referenced this issue Mar 14, 2025
@bnoordhuis
Fix exception in WeakRef.prototype.deref (#653)
3c2e7dc 
Set the object's opaque to a sentinel value instead of NULL, to stop
JS_GetOpaque2 from raising an "illegal class" exception.

Fixes: quickjs-ng/quickjs#651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ammarahm-ed