Skip to content

Run test suite under valgrind #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bnoordhuis opened this issue Nov 17, 2023 · 3 comments · Fixed by #324
Closed

Run test suite under valgrind #71

bnoordhuis opened this issue Nov 17, 2023 · 3 comments · Fixed by #324
Labels
enhancement New feature or request test

Comments

@bnoordhuis
Copy link
Contributor

Valgrind catches bugs that {A,M,UB}San won't catch. The downside is it's sloooow and maybe not something we want to run for every commit.

Test how long it takes on GHA. If it's beyond reasonable, then run it daily as a GHA cron job?
@bnoordhuis bnoordhuis added enhancement New feature or request test labels Nov 17, 2023
@saghul
Copy link
Contributor

saghul commented Nov 17, 2023

Would you run the entire 262 suite or a subset?

@bnoordhuis
Copy link
Contributor Author

The whole suite.

saghul added a commit that referenced this issue Mar 18, 2024
@saghul
Add valgrind to CI
258f081 
Fixes: #71
@saghul saghul mentioned this issue Mar 18, 2024
Merged
@saghul
Copy link
Contributor

saghul commented Mar 18, 2024

I'm trying this locally and it's unbearably slow, let's see how it does in the CI: #324 at least it seems to have caught something... #323

saghul added a commit that referenced this issue Mar 18, 2024
@saghul
Add valgrind to CI
5a17546 
Fixes: #71
saghul added a commit that referenced this issue Mar 19, 2024
@saghul
Add valgrind to CI
4ec26df 
Fixes: #71
saghul added a commit that referenced this issue Mar 20, 2024
@saghul
Add valgrind to CI
3781c2a 
Fixes: #71
bluesky950520 pushed a commit to bluesky950520/quickjs that referenced this issue Mar 14, 2025
@saghul
Add valgrind to CI
50a1ee1 
Fixes: quickjs-ng/quickjs#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add valgrind to CI quickjs-ng/quickjs
2 participants
@bnoordhuis @saghul