Skip to content

Change new API JS_SetUncatchableError before release #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bnoordhuis opened this issue Jan 14, 2025 · 0 comments · Fixed by #827
Closed

Change new API JS_SetUncatchableError before release #826

bnoordhuis opened this issue Jan 14, 2025 · 0 comments · Fixed by #827
Labels
enhancement New feature or request

Comments

@bnoordhuis
Copy link
Contributor

flag is too cryptic and should have been called something like is_uncatchable, or have been left out and been replaced with:

JS_EXTERN void JS_SetUncatchableError(JSContext *ctx, JSValue val);
JS_EXTERN void JS_ClearUncatchableError(JSContext *ctx, JSValue val);

Originally posted by @bnoordhuis in #824 (comment)
@bnoordhuis bnoordhuis added the enhancement New feature or request label Jan 14, 2025
bnoordhuis added a commit to bnoordhuis/quickjs that referenced this issue Jan 14, 2025
@bnoordhuis
Rework JS_SetUncatchableError
7480dae 
Remove the (cryptic!) `flag` argument and add JS_ClearUncatchableError.

Fixes: quickjs-ng#826
@bnoordhuis bnoordhuis mentioned this issue Jan 14, 2025
Merged
bnoordhuis added a commit that referenced this issue Jan 14, 2025
@bnoordhuis
Rework JS_SetUncatchableError (#827)
8bcc070 
Remove the (cryptic!) `flag` argument and add JS_ClearUncatchableError.

Fixes: #826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework JS_SetUncatchableError bnoordhuis/quickjs
1 participant
@bnoordhuis