Skip to content

run-test262 does not always report errors #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis opened this issue Mar 11, 2025 · 0 comments · Fixed by #971
Closed

run-test262 does not always report errors #970

bnoordhuis opened this issue Mar 11, 2025 · 0 comments · Fixed by #971
Labels
bug Something isn't working

Comments

@bnoordhuis
Copy link
Contributor

bnoordhuis commented Mar 11, 2025

$ build/run-test262 -c test262.conf -d test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw
test262.conf:38: ignoring testdir=test262/test
Result: 6/15 errors

$ echo $?
0

Vs. (note the trailing slash)

$ build/run-test262 -c test262.conf -d test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw/
test262.conf:38: ignoring testdir=test262/test
test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw//iterator-result-rejected-promise-close.js:74: unexpected error: TypeError: $DONE() not called
test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw//throw-undefined-get-return-undefined.js:64: unexpected error: TypeError: $DONE() not called
test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw//throw-undefined-return-object.js:66: unexpected error: TypeError: $DONE() not called
test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw//throw-undefined-return-not-object.js:72: unexpected error: TypeError: $DONE() not called
test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw//throw-undefined-poisoned-return.js:68: unexpected error: TypeError: $DONE() not called
test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw//throw-result-poisoned-wrapper.js:81: unexpected error: TypeError: $DONE() not called
Result: 6/15 errors, 6 new

$ echo $?
1

I suspect it causes run-test262 (both locally and on CI) to under-report test failures. edit: it's the other way around. The failures are listed in test262_errors.txt and expected. The trailing slash makes them get over-reported because of a bad check.

@bnoordhuis bnoordhuis added the bug Something isn't working label Mar 11, 2025
bnoordhuis added a commit to bnoordhuis/quickjs that referenced this issue Mar 11, 2025
Otherwise find_error() won't match entries in test262_errors.txt when
the path to `-d <path>` ends with one or more trailing slashes.

Fixes: quickjs-ng#970
bnoordhuis added a commit to bnoordhuis/quickjs that referenced this issue Mar 11, 2025
Otherwise find_error() won't match entries in test262_errors.txt when
the path to `-d <path>` ends with one or more trailing slashes.

Fixes: quickjs-ng#970
bnoordhuis added a commit that referenced this issue Mar 11, 2025
Otherwise find_error() won't match entries in test262_errors.txt when
the path to `-d <path>` ends with one or more trailing slashes.

Fixes: #970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant