Skip to content

Add pointer cast magic to avoid pedantic warnings with gcc-13 #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

Gottox
Copy link
Contributor

@Gottox Gottox commented Mar 27, 2025

The same trick is used on line 689, so I'm considering it reasonable to do the same for js_os_exec_once_init.

// ...
// line 689:
    *(void **) (&init) = dlsym(hd, "js_init_module");
// ...

The same trick is used on line 689, so I'm considering it reasonable to
do the same for js_os_exec_once_init.
@Gottox
Copy link
Contributor Author

Gottox commented Mar 27, 2025

Would it make sense to run the CI with -Wpedantic -Werror? - afaics quickjs-ng is handling pedantic just fine after this PR with clang-17/gcc-13.

@saghul
Copy link
Contributor

saghul commented Mar 27, 2025

Let's give it a try!

@saghul saghul merged commit fc31927 into quickjs-ng:master Mar 31, 2025
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants