Skip to content

Update test262 #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Update test262 #1035

merged 1 commit into from
Apr 25, 2025

Conversation

bnoordhuis
Copy link
Contributor

No description provided.

@nabetti1720
Copy link

I am concerned that the execution conditions for test262 are different between the bellard version and the NG version. I expect the NG version to include the bellard version in the test cases.

  • There is no problem with the NG version having a more advanced commit for the test262 referenced.
  • There is no problem with the NG version supporting tests that the bellard version skips or excludes. (I didn't look closely, but...)
  • It is problematic that the NG version excludes things that the bellard version does not exclude.

In addition, it seems that the bellard version has recently started supporting staging test cases. What do you think about the NG version?

Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn that's some failures to work through! 😅

@bnoordhuis bnoordhuis merged commit 2f7d349 into quickjs-ng:master Apr 25, 2025
127 checks passed
@bnoordhuis bnoordhuis deleted the update-test262 branch April 25, 2025 19:20
@bnoordhuis
Copy link
Contributor Author

Damn that's some failures to work through! 😅

@saghul It looks like a lot but most are variations of two bugs, I think. Fix the bug, fix a slew of failing tests.

supporting staging test cases

@nabetti1720 We've done that in the past but half the time upstream staging stuff gets removed again and then it's just wasted effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants