Fix Object.defineProperty with RAB typed arrays #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix handling inside Object.defineProperty and Object.defineProperties of length-tracking typed arrays whose backing resizable arraybuffers have been shrunk. Check against the actual element count rather than the original element count. Not an OOB read or write because no memory is accessed, it just didn't throw the expected TypeError exception.
saghul
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling inside Object.defineProperty and Object.defineProperties of length-tracking typed arrays whose backing resizable arraybuffers have been shrunk. Check against the actual element count rather than the original element count.
Not an OOB read or write because no memory is accessed, it just didn't throw the expected TypeError exception.