Skip to content

Implement Error.stackTraceLimit #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Implement Error.stackTraceLimit #226

merged 1 commit into from
Dec 19, 2023

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Dec 19, 2023

We default to 10 with a max cap of 64.

Ref: https://v8.dev/docs/stack-trace-api

@saghul saghul requested a review from bnoordhuis December 19, 2023 15:02
@saghul
Copy link
Contributor Author

saghul commented Dec 19, 2023

@bnoordhuis PTAL!

PS: Are you cooking something or shall I make a new release?

Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you cooking something or shall I make a new release?

Still working on that Basic_Emoji thing but that doesn't have to hold up anything.

We default to 10 with a max cap of 64.

Ref: https://v8.dev/docs/stack-trace-api
@saghul saghul force-pushed the error-stackTraceLimit branch from 2db771f to c3a0d6e Compare December 19, 2023 20:58
@saghul saghul merged commit 4c929c5 into master Dec 19, 2023
@saghul saghul deleted the error-stackTraceLimit branch December 19, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants