Skip to content

Implement getTimezoneOffset for Win32 #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Conversation

afulsamet
Copy link
Contributor

Useful links

Notes

The bias is the difference, in minutes, between UTC time and local time.

@chqrlie
Copy link
Collaborator

chqrlie commented Mar 3, 2024

Hello! The checks for windows-mingw targets failed because <windows.h> and friends are only included if _MSC_VER is defined whereas the patch depends on _WIN32 being defined.

I am not fully familiar with the mingw system, I guess the windows headers should be included if _WIN32 is defined, not just for the Microsoft compiler.

@afulsamet
Copy link
Contributor Author

afulsamet commented Mar 3, 2024

Hello! The checks for windows-mingw targets failed because <windows.h> and friends are only included if _MSC_VER is defined whereas the patch depends on _WIN32 being defined.

I am not fully familiar with the mingw system, I guess the windows headers should be included if _WIN32 is defined, not just for the Microsoft compiler.

I tested new commit with GCC 13.2.0 (MinGW) and Clang 17.0.6 (MSVC), it works now.

@saghul saghul merged commit d11f5f6 into quickjs-ng:master Mar 3, 2024
@saghul
Copy link
Contributor

saghul commented Mar 3, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants