Add utility functions for string to integer conversions #366
Conversation
- add `is_upper_ascii()` and `to_upper_ascii()` - add `u32toa()`, `i32toa()`, `u64toa()`, `i64toa()` `u32toa_radix()`, `u64toa_radix()`, `i64toa_radix()` - use direct converters instead of `snprintf()` - copy NaN and Infinity directly in `js_dtoa1()` - optimize `js_number_toString()` for small ints - use `JS_NewStringLen()` instead of `JS_NewString()` when possible - add more precise conversion tests in microbench.js
Yes, gcc 32-bit optimizes the naive copy loop beyond sanity (uses SIMD instructions) which causes reads beyond the array boundaries. I am investigating other approaches. WIP |
- move `is_be()` to cutils.h - use register shift variant for `u32toa` and `u64toa` - use length_loop variant for `u32toa_radix` and `u64toa_radix` - add extensive benchmark for integer conversion variants in tests/test_conv.c
|
I ran extensive benchmarks to test various methods to convert integers to strings in base 10 or others. |
chqrlie
changed the title
is_upper_ascii()andto_upper_ascii()u32toa(),i32toa(),u64toa(),i64toa()u32toa_radix(),u64toa_radix(),i64toa_radix()snprintf()js_dtoa1()js_number_toString()for small intsJS_NewStringLen()instead ofJS_NewString()when possible