Avoid using white color in REPL #372
Conversation
It's not visible on white background terminals.
| @@ -58,21 +57,20 @@ import * as os from "os"; | |||
| bright_blue: "\x1b[34;1m", | |||
| bright_magenta: "\x1b[35;1m", | |||
| bright_cyan: "\x1b[36;1m", | |||
| bright_white: "\x1b[37;1m", | |||
There was a problem hiding this comment.
You should not remove the color definitions, just change the style definitions.
At some point it should be possible to customize the styles so the colors should all be defined.
There was a problem hiding this comment.
I'll revert that change.
| 'keyword': 'bright_magenta', | ||
| 'function': 'bright_yellow', | ||
| 'type': 'bright_magenta', |
There was a problem hiding this comment.
keywords should not be the same color as types.
is there a way to test the terminal default color so we can use black on a white background for the default style?
There was a problem hiding this comment.
I don't know if that is possible at all. I made the choice based on how VSCode seems to color stuff. No strong opinion, so I'm open to suggestions!
There was a problem hiding this comment.
There are 2 ways to retrieve the default colors from the terminal:
- using the
COLORFGBGenvironment variable which might be maintained to reflect the terminal settings. Editors such asvimsupposedly use this to adjust their color settings. This is the easiest. - using OSC escape sequences: sending
\e]11;?\ato the terminal should trigger a terminal response for the default background color. iTerm2 sends me this:\e]11;rgb:0000/0000/0000\afor a black background. Similarly,\e]10;?\aresponds with the foreground color, namely\e]10;rgb:c7f1/c7f1/c7f1\ain may case for a medium grey.
I am going to implement the first method along with VSCode default colors for a light theme.
There was a problem hiding this comment.
Cool, shall I drop this then?
There was a problem hiding this comment.
Cool, shall I drop this then?
I just filed PR #383 with dark and light selectable themes and autoselect the light scheme if the terminal background is not black, based on the COLORFGBG environment variable. So I guess you can drop this one.
It's not visible on white background terminals.
New colors: