Fix encoding bug in js_dtoa_radix #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chqrlie
commented
May 7, 2024
chqrlie
commented
- fix radix conversion rounding code: incrementing the digit does not work for '9'. We can assume ASCII so it works for all other digits, especially all letters
- also avoid recomputing the string length
- fix radix conversion rounding code: incrementing the digit does not work for '9'. We can assume ASCII so it works for all other digits, especially all letters - also avoid recomputing the string length
saghul
approved these changes
May 7, 2024
bnoordhuis
pushed a commit
to bnoordhuis/quickjs
that referenced
this pull request
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.