Support (de)serializing Map and Set objects #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Aug 19, 2024
| goto fail; | ||
| if (bc_get_leb128(s, &prop_count)) | ||
| goto fail; | ||
| for(i = 0; i < prop_count; i++) { |
There was a problem hiding this comment.
Suggested change
| for(i = 0; i < prop_count; i++) { | |
| for (i = 0; i < prop_count; i++) { |
There was a problem hiding this comment.
I'm merely following the predominant style for for loops here (of the 533 for statements in quickjs.c, 66.8% are written this way.)
There was a problem hiding this comment.
Fabrice and i differ on this, I always put a space after if, for, while, switch, return with a value etc. Fabrice is less adamant about it :)
| JS_FreeValue(ctx, rv); | ||
| JS_FreeValue(ctx, argv[0]); | ||
| JS_FreeValue(ctx, argv[1]); | ||
| argv[0] = JS_UNDEFINED; |
There was a problem hiding this comment.
Is this necessary since yoy are about to return?
There was a problem hiding this comment.
Yes, because it's inside a loop, otherwise we can end up double-freeing argv[1] on the next iteration.
(And I'm clearing argv[0] for clarity's sake, otherwise a casual reader will stop and think: "Why one and not the other?")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #482