Silence noisy (and useless) MSVC warnings #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
force-pushed
the
silence-msvc-warnings
branch
5 times, most recently
from
3df48ec to
b1d1c51
Compare
|
This one is ready, the build output is not so noisy now. The silenced warnings mostly match whe ones we have for other compilers. |
saghul
force-pushed
the
silence-msvc-warnings
branch
from
b1d1c51 to
0396e71
Compare
bnoordhuis
approved these changes
Sep 11, 2024
CMakeLists.txt
Outdated
| xcheck_add_c_compiler_flag(/wd4711) | ||
| xcheck_add_c_compiler_flag(/wd4820) | ||
| xcheck_add_c_compiler_flag(/wd4996) | ||
| xcheck_add_c_compiler_flag(/wd5045) |
There was a problem hiding this comment.
It would be helpful to have comments explaining what warnings they suppress and/or mentions their gcc counterpart, e.g.
xcheck_add_c_compiler_flag(/wd4100) # -Wno-unused-parameter
d5cea0f to
909624c
Compare
saghul
force-pushed
the
silence-msvc-warnings
branch
from
909624c to
19d2e7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.