Add ThreadSanitizer support #558
Conversation
quickjs.h
Outdated
| @@ -1022,7 +1022,6 @@ JS_EXTERN int JS_SetModuleExportList(JSContext *ctx, JSModuleDef *m, | |||
|
|
|||
| JS_EXTERN const char* JS_GetVersion(void); | |||
|
|
|||
| #undef JS_EXTERN | |||
There was a problem hiding this comment.
Maybe this is a problem for those modules that dfeine something with the same name?
Since the runner works in Unix only, we could leave this as is perhaps, and drop the static ?
There was a problem hiding this comment.
Yes, fair point, I was ambivalent on whether to make this change or not.
The reason I did is because otherwise it breaks if a downstream user adds -fvisibility=hidden to the build flags, builds the shared library, and run-test262. Probably not very likely.
There was a problem hiding this comment.
From our own CI 🙈
/usr/bin/ld: CMakeFiles/run-test262.dir/run-test262.c.o: warning: relocation against `js_atomics_mutex' in read-only section `.text'
/usr/bin/ld: CMakeFiles/run-test262.dir/run-test262.c.o: in function `js_agent_sleep':
run-test262.c:(.text+0x45a): undefined reference to `js_atomics_mutex'
|
Grr... Fails on CI; doesn't reproduce locally. Add CI logging; problem disappears 😠 |
|
Magical printf! |
|
I'm going to throw in the towel, I can't get it past CI. @saghul wdyt, should I merge this without turning it on on the CI, or just scrap it altogether? (I'm inclined towards scrapping. Likely to bitrot without regular testing.) |
|
Maybe one last show with Ubuntu 24.04 as the image? it's not yet "latest" which threw me off when testing mimalloc, maybe a newer version helps? |
|
Nope, same issue. Towel -> ring. |
|
Oh well! |
Fixes: #557