Improve performance of variable resolver #668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a LRU cache to speed up resolving variables in really large source files. The test case from the linked issue spends about 50% of its time inside resolve_scope_var(). With this change that drops by about 20% and gives a 10% overall speedup. Fixes: quickjs-ng#456
|
Superseded by #672. Kind of a shame because I rather like how the LRU code turned out. Oh well 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a LRU cache to speed up resolving variables in really large source files.
The test case from the linked issue spends about 50% of its time inside resolve_scope_var(). With this change that drops by about 20% and gives a 10% overall speedup.
Fixes: #456
I'm not completely sold on this change yet:
unclear if it interacts correctly with
with(but I guess CI will tell - edit: interacts poorly)adds complexity for an at best okay-ish speedup
(2) can maybe be improved by caching variables from parent function scopes as well but that gets complex fast.