Skip to content

Update projects.md to include GodotJS #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

ialex32x
Copy link
Contributor

@ialex32x ialex32x commented Jan 7, 2025

Hi, may I append my project GodotJS to the list in projects.md?

@saghul saghul merged commit af16390 into quickjs-ng:master Jan 7, 2025
@saghul
Copy link
Contributor

saghul commented Jan 7, 2025

Of course!

@bnoordhuis
Copy link
Contributor

For my curiosity, in https://github.com/godotjs/GodotJS?tab=readme-ov-file#supported-platforms you list quickjs.impl as mostly complete but quickjs.impl (quickjs-ng) as predominantly incomplete. Why is that? It should be a drop-in replacement, right?

@ialex32x
Copy link
Contributor Author

ialex32x commented Jan 8, 2025

For my curiosity, in https://github.com/godotjs/GodotJS?tab=readme-ov-file#supported-platforms you list quickjs.impl as mostly complete but quickjs.impl (quickjs-ng) as predominantly incomplete. Why is that? It should be a drop-in replacement, right?

Ah, there are some test works on my side (check the built godot app works properly on each platform). QuickJS-NG is fantastic to use. For windows, I'll add comments in README right away, about the requirement of clang compiler to build with QuickJS-NG (my current environment on windows is MSVC, and it fails to compile). I've tested without errors on Linux/Android today.

BTW, may I submit another PR to add two functions JS_IsMap and JS_IsPromise (very simple, like the JS_IsArrayBuffer which already exists)? Otherwise, the only way I could use is JS_IsInstanceOf which seems relatively more expensive.

@saghul
Copy link
Contributor

saghul commented Jan 8, 2025

Those PRs would be welcome!

About the compiler: we support MSVC >= 2019 out of the box. Can you share details on what compilation issues you've ran into?

@ialex32x
Copy link
Contributor Author

ialex32x commented Jan 8, 2025

I'm using MSVC 2022, it complains tons of errors about atomics, such as vcruntime_c11_stdatomic.h(36): Error C2061 : syntax error: identifier 'atomic_bool' . I tried the compiler option /experimental:c11atomics but it doesn't help. I'll investigate into it tomorrow, and report an issue with more details if it's not resolved on my side.

@saghul
Copy link
Contributor

saghul commented Jan 8, 2025

We use that flag in the project. Do you use CMake to compile the QuickJS target or something else?

@ialex32x
Copy link
Contributor Author

ialex32x commented Jan 9, 2025

Godot uses scons. I figured it out after reading the cmake file. /std:c11 was missing in my scons build script 😂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants