Skip to content

Handle return value of JS_ToFloat64 #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions quickjs.c
Original file line number Diff line number Diff line change
Expand Up @@ -6765,6 +6765,8 @@ static void build_backtrace(JSContext *ctx, JSValue error_val, JSValue filter_fu
saved_exception = JS_GetException(ctx);

// Extract stack trace limit.
// Ignore error since it sets d to NAN anyway.
// coverity[check_return]
JS_ToFloat64(ctx, &d, ctx->error_stack_trace_limit);
if (isnan(d) || d < 0.0)
stack_trace_limit = 0;
Expand Down