Skip to content

Don't use time in CI #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Don't use time in CI #964

merged 1 commit into from
Mar 11, 2025

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Mar 10, 2025

No description provided.

@bnoordhuis
Copy link
Contributor

Is this because of #961 (reply in thread)? He's mistaken, time(1) exits with the exit code of the process being timed.

That Result: 83/79396 errors is somewhat concerning but it's a pre-existing condition that this PR won't fix. run-test262 distinguishes between "failed" and "errored"; the former doesn't affect the exit code but maybe it should.

@saghul
Copy link
Contributor Author

saghul commented Mar 11, 2025

I know it won't fix that and also nothing is broken there 😅

We are, however inconsistent in that we are only timing one run. GH already times each step and since you added multi-threading is definitely fast enough so I thought we could drop it.

@chqrlie
Copy link
Collaborator

chqrlie commented Mar 11, 2025

The reason I put the time command in the test make targets was to have a simple consistent benchmark in addition to checking for correctness. That allowed me to detect performance regressions (or expected progressions).

I don't see a compelling reason to remove it.

@saghul
Copy link
Contributor Author

saghul commented Mar 11, 2025

Well, but why on the CI and only in one job? You can do that on your make invocation...

@chqrlie
Copy link
Collaborator

chqrlie commented Mar 11, 2025

Well, but why on the CI and only in one job? You can do that on your make invocation...

Of course not needed in the CI when invoking make test262, this can be removed.
I was mistaken: I stopped using the time command when we added the -t option to compute and display the timings in run-test262.

@saghul saghul merged commit da67188 into master Mar 11, 2025
128 checks passed
@saghul saghul deleted the ci-no-time branch March 11, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants