Sync from bellard/ #984
Merged
Sync from bellard/ #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 17, 2025 13:11
…property is found in a prototype
|
That second commit likely applies better if you revert 0b0b794 first. |
Ah, thanks for the pointer! Do we want to go with the approach on bellard/ or are we ok as is? |
|
I'm okay with using the bellard/master commit. It doesn't really matter from a functional change perspective, it's mostly cosmetic. |
|
New BigInt implementation: bellard/quickjs@61e8b94 |
|
New dtoa (Tiny float64 printing and parsing library) implementation: bellard/quickjs@9936606 |
|
There is a couple of large ones, I'll have to break this down into a few PRs I think. |
|
@bnoordhuis PTAL. I'll make separate PRs for the BigInt and dtoa changes, since they are quite large. |
bnoordhuis
approved these changes
Mar 23, 2025
|
Can do! |
This reverts commit 0b0b794. This makes our code closer to bellard/quickjs, which makes applying the commit right after this one simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently missing:
bellard/quickjs@25aaa77bellard/quickjs@9bd10d8The former doesn't apply cleanly so I'll have to massage it. The latter seems to rely on some changes on how var args are kept that we currenly differ on. Thoughts on that @bnoordhuis ?