Docker image build #1506
Merged
Docker image build #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we can first merge the PR to have the nightly docker image and have another PR for the release, as you like |
fmassot
reviewed
May 22, 2022
| inputs: | ||
| version: | ||
| description: 'Version' | ||
| required: false |
There was a problem hiding this comment.
Not sure why version is not required
There was a problem hiding this comment.
For production build we don't specify version in order to have an image quickwit/quickwit as opposed to quickwit/quickwit-nightly
fmassot
reviewed
May 22, 2022
| node-version: 16 | ||
| cache: 'yarn' | ||
| cache-dependency-path: quickwit-ui/yarn.lock | ||
| - run: make build-ui |
There was a problem hiding this comment.
For this build, I guess it would be nice to include the UI build inside the Dockerfile as we are doing everything there.
fmassot
approved these changes
May 22, 2022
@fmassot I actually was referring to the custom action you did for the binaries. It's only for the nightly as of now. |
evanxg852000
force-pushed
the
fix-1219-docker
branch
from
fbbd54f to
a185d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docker image build to ci
Part of #1219
@fmassot I think what we are missing is having the binaries build for
.github/workflows/publish_release_packages.ymlShould I add it here?