Force rlang bindings on unload #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually we should probably unconditionally force on unload for all packages, in case of dangling references. Otherwise unforced lazy bindings get decompress errors if the namespace is unloaded and inconsistency issues if it is reloaded. What do you think Jim? |
|
yeah I think forcing on unload unconditionally seems like the right approach. |
lionel-
force-pushed
the
rlang-force
branch
2 times, most recently
from
53c20c8 to
5e3e21b
Compare
|
Is this ready to be merged @jimhester? |
jimhester
approved these changes
Jun 14, 2021
|
Sure you can merge it whenever you are ready, thanks for the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent lazy rlang bindings to be resolved in the new partially created namespace when forced from pkgload itself.