Implement allow_empty #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #252
DavisVaughan
approved these changes
Aug 11, 2022
R/eval-walk.R
Outdated
Comment on lines
107
to
111
| return(set_names(pos, NULL)) | ||
| } | ||
|
|
||
| check_empty(pos, allow_empty, call = call) | ||
|
|
There was a problem hiding this comment.
Does the check need to be before this early return?
lionel-
approved these changes
Aug 11, 2022
| @@ -113,6 +121,12 @@ ensure_named <- function(pos, | |||
| pos | |||
| } | |||
|
|
|||
| check_empty <- function(x, allow_empty = TRUE, call = caller_env()) { | |||
There was a problem hiding this comment.
Nit: Though it reduces some repetition here, it seems unusual for a check_ function to take a boolean variable disabling the check. I think the general pattern is more like
if (check) {
check_foo(x)
}
tests/testthat/_snaps/eval-walk.md
Outdated
| Code | ||
| ensure_named(integer(), allow_empty = FALSE) | ||
| Condition | ||
| Error in `check_empty()`: |
There was a problem hiding this comment.
I don't understand why it's showing check_empty() here.
There was a problem hiding this comment.
I think because call was missing previously
Co-authored-by: Davis Vaughan <[email protected]> Co-authored-by: Lionel Henry <[email protected]>
Conflicts: NEWS.md tests/testthat/test-eval-walk.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252
Do you think I need to add an
error_argto these errors?