Skip to content

Spelling #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 13, 2019
Merged

Spelling #443

merged 10 commits into from
Feb 13, 2019

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 13, 2019

Proposed Changes

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

There are a number of benefits of using correct spelling, one is that it makes it easier to read, another is that it makes it easier to search/cross reference, another is that it reduces ambiguity/confusion.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

I'm not claiming to be an erlang expert/user (we're investigating using RabbitMQ for a system, and I like to test the waters of projects to get a sense of how healthy they are with small changes). I haven't yet set up an erlang environment. So I haven't run the tests yet (I can, and understand that the contribution guide encourages me to do so).

@michaelklishin michaelklishin merged commit 6b836c5 into rabbitmq:master Feb 13, 2019
@michaelklishin
Copy link
Contributor

Thank you!

@jsoref jsoref deleted the spelling branch February 13, 2019 08:39
acogoluegnes added a commit to rabbitmq/rabbitmq-jms-client that referenced this pull request Jul 5, 2019
acogoluegnes added a commit to rabbitmq/rabbitmq-jms-client that referenced this pull request Jul 5, 2019
Following up on
rabbitmq/rabbitmq-java-client#443.

(cherry picked from commit c926782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants