Allow changing queue names during recovery #693
Merged
+65
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow a consumer to register a callback to change the name of a queue during recovery. This is useful when dealing with transient and auto-delete queues that are susceptible to 404 NOT_FOUND client recovery errors and binding corruption issues during cluster node cycles/upgrades. When a client reconnects and redeclares the queue, we expose a timing issue due to the server trying to cleanup the queue at the same time the client is coming back to redeclare it.
The easy existing alternative is to use server named queues. However, with that consumers have no ability to provide a useful queue name that makes it easy to tell what application a queue belongs too from a monitoring/troubleshooting perspective.
This enhancement allows for applications to still name queues in meaningful ways, but to then support modifying that name during a recovery to avoid the timing issues described above.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments