Consider max unconfirmed messages in dynamic batch configuration #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small value for max unconfirmed messages can impact the dynamic batch mechanism. This commit sets the min batch size to half the max unconfirmed messages value if it is less than the configured batch size. References #757
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…x-unconfirmed Consider max unconfirmed messages in dynamic batch configuration
|
Hi @acogoluegnes, thanks for the update, just to confirm, the snapshot would be com.rabbitmq:stream-client:1.2.0-SNAPSHOT from this repo: https://rabbitmq.github.io/rabbitmq-stream-java-client/snapshot/htmlsingle/#snapshots ? The problem may be on my end, but I wasn't able to download it. |
|
This is the correct link the snapshot repository. I updated the project to use Sonatype's central portal last week, including for snapshots, but it seems it is down today, sorry about this. |
|
@pvaiko The snapshot repository is available again. |
|
@acogoluegnes thank you very much, just tested, works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small value for max unconfirmed messages can impact the dynamic batch mechanism. This commit sets the min batch size to half the max unconfirmed messages value if it is less than the configured batch size.
References #757