feat: make it possible to link to a tab #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it possible to link to a tab. For example, https://www.racket-lang.oth/#ide-support would link to the "IDE support" tab. Each tab change will modify the URL so that viewers can copy the link. Furthermore, remove the symlinks community.html and irc-chat.html, and make them redirect to the `#community` tab. Fixes racket#209
|
This is now ready for review. The staging site is at https://sorawee.github.io/tmp/. |
|
tested https://sorawee.github.io/tmp/#community |
|
Tested on mobile safari iOS PASSED |
|
Tested iOS Firefox passed |
|
tested google chrome win 10 PASSED |
|
todo - I am unable to test these
|
|
I tested this successfully on iOS Safari a while back. |
|
|
firefox on windows 10 and android work |
|
@rfindler @mfelleisen: is it OK to merge this? Many people have tested and it seems there's no problem. |
|
Okay by me to merge.
|
|
Thanks everyone for testing and feedback! I assume that there will soon be a change related to RacketCon, and my change will be deployed along with the RacketCon change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it possible to link to a tab. For example,
https://www.racket-lang.org/#ide-support would link to the "IDE support" tab.
Each tab change will modify the URL so that viewers can copy the link.
Furthermore, remove the symlinks community.html and irc-chat.html,
and make them redirect to the
#communitytab.The commit depends on #254.
Fixes #209