New Maintainers Needed

[metaskills]

Want to help move the adapter project forward? Just ping us with a good PR and you get access. Please avoid (just works for me) hacks and show ownership for working software that works for everyone.

[bigtunacan]

@metaskills, I've implemented part of the SQLServerDatabaseTasks class, enough to at least get up to 4.1.8 compatibility while I continue to work on the rest of the interface.

Currently I'm working on tests; I ran into some issues with failing tests that are part of Rails suite you are importing. I'm curious how you have handled these in the past.

To give a concrete example; here is a test model that is setup in the Rails test suite that fails when run against the sqlserver adapter.

scope :including_last_pet, -> {
  select(%q[
    owners.*, (
      select p.pet_id from pets p
      where p.owner_id = owners.owner_id
      order by p.name desc
      limit 1
    ) as last_pet_id
  ]).includes(:last_pet)
}

The issue here is that limit is being used intead of the SQL Server equivalent top. Do you as a rule just ignore these failures; or have you been using some means to monkey patch over these? I'm asking as it would seem ideal to have a completely green test suite when things are working as expected.

[bigtunacan]

@metaskills Would there be a possibility of doing a short Skype/Google Hangout/Gitter/other to chat? I do have a couple of questions still related to testing and I think it would be faster/easier with a live discussion. We could do this anytime that is convenient for you.

[metaskills]

Hey @bigtunacan I would love to, but my time is really bad till next year :( ping me again soon'ish

[bigtunacan]

@metaskills no worries. It took me a while, but I've wrapped my head around it enough to get through most of it. I have a couple of failing tests that I'm working through still, but close to wrapping up. I pinged you on Twitter yesterday (@JSeeley over there).

[bigtunacan]

I have created pull request #366 which gets the adapter up to compatibility with Rails v4.1.8 and fixes issue #363 which I had reported earlier.

I plan to continue moving forward with the rest of the implementation of the ActiveRecord::Tasks interface to fully support Rails v4.2+.

@metaskills let me know if you can give me maintainer/commit rights as well as the ability to deploy updated RubyGems. I have at least one other developer who can help to support this as well.

Also if it helps set your mind at ease; I am also the official maintainer of the rails3-jquery-autocomplete gem, https://rubygems.org/gems/rails3-jquery-autocomplete, so this is not an entirely new experience for me.

Thanks.

[zenom]

Some of us at work are also looking at helping with the responsibility but we have not been able to commit to it yet.

[metaskills]

@zenom Have you made any pull requests yet?

[zenom]

Not yet. We have not had time yet. 

—
Sent from Mailbox

On Sat, Dec 27, 2014 at 12:20 PM, Ken Collins notifications@github.com
wrote:

@zenom Have you made any pull requests yet?

Reply to this email directly or view it on GitHub:
#364 (comment)

[metaskills]

@zenom I am working on adapter change now for 4.1 and 4.2 so stay tuned. FYI, it helps to get commit rights if you have contributed.

[bigtunacan]

@metaskills Updated a couple of things on pull request #366

[muloka]

I have contributed though not as of late. If memory serves me right @wbond made some notable contributions to get the adapter running on 4.0.

[metaskills]

I have finished the initial v4.2.0 gem. Some info here. http://metaskills.net/2015/01/25/activerecord-sqlserver-v4.2.0---code-name-kantishna/

A good place to get started for helping would be to claim and work on one of the identified issues in our milestone here https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/milestones/4-2-stable

[metaskills]

Also, with the latest work, I am kind of in the game again. Now that we are on 2012 and upward with OFFSET/FETCH, I'm stoked.