When using FETCH without specific ordering, use projection to order
#1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
changed the title
FETCH without ordering try to order using projection rather than the primary key
aidanharan
changed the title
FETCH without ordering try to order using projection rather than the primary keyFETCH without specific ordering, use projection to order
There was a problem hiding this comment.
Pull Request Overview
This PR improves the ordering behavior when using FETCH without an explicit ORDER BY clause by trying to use a valid projection for ordering before falling back to the primary key.
- Adds tests for implicit order behavior in SQLServer queries
- Updates the SQLServer visitor to detect and use projections for ordering
- Updates the CHANGELOG with the new feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/cases/implicit_order_test_sqlserver.rb | Introduces tests for different ordering scenarios when using FETCH |
| lib/arel/visitors/sqlserver.rb | Implements new logic to use projections for ordering if no explicit order is given |
| CHANGELOG.md | Documents the new feature regarding projection-based ordering |
|
Closing as the PR doesn't resolve the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the ordering behavior when using FETCH without an explicit ORDER BY clause by trying to use a valid projection for ordering before falling back to the primary key.
Related to #1319