Skip to content

Add support for npm 9+ #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Add support for npm 9+ #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ec3041
Add support for npm 9+
jcoyne Nov 29, 2022
b924206
Simplify case
dhh Dec 14, 2022
043e1d5
Simplify case
dhh Dec 14, 2022
c4edb7e
Simplify case
dhh Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/install/esbuild/install.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@
say "Add build script"
build_script = "esbuild app/javascript/*.* --bundle --sourcemap --outdir=app/assets/builds --public-path=assets"

if (`npx -v`.to_f < 7.1 rescue "Missing")
say %(Add "scripts": { "build": "#{build_script}" } to your package.json), :green
else
case `npx -v`.to_f
when 7.1...8.0
run %(npm set-script build "#{build_script}")
run %(yarn build)
when 8.0..
run %(npm pkg set scripts.build="#{build_script}")
run %(yarn build)
else
say %(Add "scripts": { "build": "#{build_script}" } to your package.json), :green
end
10 changes: 7 additions & 3 deletions lib/install/rollup/install.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@
say "Add build script"
build_script = "rollup -c rollup.config.js"

if (`npx -v`.to_f < 7.1 rescue "Missing")
say %(Add "scripts": { "build": "#{build_script}" } to your package.json), :green
else
case `npx -v`.to_f
when 7.1...8.0
run %(npm set-script build "#{build_script}")
run %(yarn build)
when 8.0..
run %(npm pkg set scripts.build="#{build_script}")
run %(yarn build)
else
say %(Add "scripts": { "build": "#{build_script}" } to your package.json), :green
end
10 changes: 7 additions & 3 deletions lib/install/webpack/install.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@
say "Add build script"
build_script = "webpack --config webpack.config.js"

if (`npx -v`.to_f < 7.1 rescue "Missing")
say %(Add "scripts": { "build": "#{build_script}" } to your package.json), :green
else
case `npx -v`.to_f
when 7.1...8.0
run %(npm set-script build "#{build_script}")
run %(yarn build)
when 8.0..
run %(npm pkg set scripts.build="#{build_script}")
run %(yarn build)
else
say %(Add "scripts": { "build": "#{build_script}" } to your package.json), :green
end