Update Heroku instructions to include buildpack sequence #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this necessary? Heroku seems to have it installed by default, correct me if i'm wrong. |
|
I was following the instructions on a (nearly) vanilla rails app and ran into #1282 . This was my issue. Just trying make sure others behind me don't hit the same (extremely frustrating) obstacle. |
|
We had to do this by hand as well. |
|
cc @hone |
|
I ran into the same problem, thanks for the fix. I also created an issue in the ruby buildpack repo as I believe that is where this should be fixed. |
|
We also had to do this. It's also helpful to specify the version of node / yarn in package.json. I think it's worth mentioning in the PR. |
|
Looks like this has been fixed already on the Heroku buildpack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.