Skip to content

Make compilation digest file visible #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

starsirius
Copy link
Contributor

@starsirius starsirius commented Jul 19, 2018

Test pack caching was introduced in #539, and users are able to specify a desired cache_path in the config. The cache path is used potentially by other caches, such as babel-loader.

From a user's perspective, it can be confusing not seeing the compilation digest file by following the cache_path, but seeing other cache files such as babel-loader caches. This makes it consistent.

@gauravtiwari gauravtiwari merged commit bbe331d into rails:master Aug 10, 2018
@gauravtiwari
Copy link
Member

thanks @starsirius 🍰

@starsirius
Copy link
Contributor Author

@gauravtiwari Yay! Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants