Run yarn check --verify-tree as part of the yarn integrity check #1774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the yarn documentation[1]: `yarn check --integrity` checks that versions and hashed values of the package contents in the project’s package.json match those in yarn’s lock file. That doesn't actually check that the packages are actually installed in node_modules. To check that we need to run `yarn check --verify-tree` [1]: https://yarnpkg.com/lang/en/docs/cli/check/
|
thanks :) |
|
FYI: this introduced a breakage for users with a non-standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found an issue in an application in which some packages where missing from
node_modulesbut webpacker didn't give any warning message.Steps to reproduce:
node_modulesExpected behaviour:
I see a message:
Your Yarn packages are out of date!Actual behaviour:
The app runs as usual and the compilation process fails.
Fix
It turns out
yarn check --integritydoesn't actually checks the whole integrity ofnode_modules. From the yarn documentation:We need both
yarn check --integrityandyarn check --verify-tree:Also it would be better to advise to run
yarn install --check-files. Otherwise, missing files fromnode_moduleswill be ignored.