Enable static asset extensions to be overwritten from app config #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreyks
force-pushed
the
fix-static-extensions
branch
from
40e3cda to
b62ea7f
Compare
dreyks
force-pushed
the
fix-static-extensions
branch
from
b62ea7f to
027afc8
Compare
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can only add more custom static asset extensions to app's webpacker config. If you remove some of them (e.g. for them to be loaded by url-loader) the default webpacker config merges them back in
So let's treat them the same way we do the usual extensions i.e. delete the default list if there's a user-provided one