Nodejs upgrade #2228
Merged
Nodejs upgrade #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2019 23:13
|
thanks @smondal |
|
Would it be possible to set 8.10 as a minimum? Ubuntu LTS doesn't provide 8.16 and I think quite a number of servers run plain Ubuntu LTS. |
|
Also, Travis uses Xenial which comes with node 8.12.0. |
jbielick
added a commit
to jbielick/webpacker
that referenced
this pull request
Feb 10, 2020
8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package. rails#2228
jakeNiemiec
added a commit
that referenced
this pull request
Feb 10, 2020
#2454) * Allow node.js 8.9 engine compatibility 8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package. #2228 * restrict to compatible yarn engine versions Co-Authored-By: Jake Niemiec <[email protected]> * restrict to compatible node engine versions As 13 has been released, an upper limit is prudent as well. Co-Authored-By: Jake Niemiec <[email protected]> Co-authored-by: Jake Niemiec <[email protected]>
KingTiger001
added a commit
to KingTiger001/Rails-web-pack-project
that referenced
this pull request
Jan 15, 2023
…) (#2454) * Allow node.js 8.9 engine compatibility 8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package. rails/webpacker#2228 * restrict to compatible yarn engine versions Co-Authored-By: Jake Niemiec <[email protected]> * restrict to compatible node engine versions As 13 has been released, an upper limit is prudent as well. Co-Authored-By: Jake Niemiec <[email protected]> Co-authored-by: Jake Niemiec <[email protected]>
smartech7
pushed a commit
to smartech7/ruby-webpacker
that referenced
this pull request
Aug 4, 2023
…) (#2454) * Allow node.js 8.9 engine compatibility 8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package. rails/webpacker#2228 * restrict to compatible yarn engine versions Co-Authored-By: Jake Niemiec <[email protected]> * restrict to compatible node engine versions As 13 has been released, an upper limit is prudent as well. Co-Authored-By: Jake Niemiec <[email protected]> Co-authored-by: Jake Niemiec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the change log from Node 6 to 8. No other changes required except version.
As Node Js still support 8, So I am changing from 6 to 8.
https://github.com/nodejs/wiki-archive/blob/master/Breaking-changes-between-v6-LTS-and-v8-LTS.md