Skip to content

Revert of production env enforcement #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 7, 2019
Merged

Revert of production env enforcement #2341

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc57a00
Revert d8dd4460144e63a9120290631c492aba3cbea332
coding-red-panda Oct 30, 2019
0cd8dfb
Update compile.rake
coding-red-panda Oct 30, 2019
976fc9c
Update rake_tasks_test.rb
coding-red-panda Oct 30, 2019
293263b
Update rake_tasks_test.rb
coding-red-panda Oct 30, 2019
efd4225
Update rake_tasks_test.rb
coding-red-panda Oct 30, 2019
6974048
Update rake_tasks_test.rb
coding-red-panda Oct 30, 2019
88be57f
Using @rossta solution to combine both behaviors
Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tasks/webpacker/compile.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ end
namespace :webpacker do
desc "Compile JavaScript packs using webpack for production with digests"
task compile: ["webpacker:verify_install", :environment] do
Webpacker.with_node_env("production") do
Webpacker.with_node_env(ENV.fetch("NODE_ENV", "production")) do
ensure_log_goes_to_stdout do
if Webpacker.compile
# Successful compilation!
Expand Down