Add test for check_node, check_yarn tasks #2457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a valid semver engine version could be an illformed gem requirement, which raising an exception during the parsing of this value from the package.json in either of these tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A valid semver engine version could be an illformed gem requirement, which raising an exception during the parsing of this value from the package.json in either of these tasks.
This caught me by surprise and I would have hoped the test suite would catch it, so I've added two tests—one for each of the
check_rake tasks. See the failure in the build for more info.Approach
Add a test that fails when the engine version in package.json fails to parse in ruby.