Add webpack_assets_path_tag to apply application asset host to dynamic/lazy chunk source path
#2636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #2219 (comment), there was no way to put dynamic/lazy chunks behind the CDN without precompiling
WEBPACKER_ASSET_HOST. This approach works if you're able to determine CDN host during the assets compilation stage, but in some cases, it's not possible. For instance, when we run a dockerized application where a single Docker image is intended to be reused in multiple environments and installations.The proposed changes allow overriding
__webpack_public_path__in runtime and take into account Rails appconfig.action_controller.asset_hostsetting. Besides, this is a convenient Webpack way to set Webpack'spublicPathon the fly.Sorry, I can't find your release policy. Should I backport this feature to Webpacker 4.x as well?