Skip to content

Add .coffee extension to the babel. #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Conversation

gencer
Copy link
Contributor

@gencer gencer commented Jan 14, 2021

CoffeeScript both included as a rule in rules/ and also in resolves but its not processed with babel. This also fixes #2845. See the comments of that issue for more details.

See coffee: https://github.com/rails/webpacker/blob/master/package/rules/coffee.js

Also resolve:

extensions: ['.js', '.jsx', '.mjs', '.ts', '.tsx', '.coffee'],

@gencer
Copy link
Contributor Author

gencer commented Jan 14, 2021

Note: Failing tests are about nokogiri.

Resolving dependencies...
nokogiri-1.11.1-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is
incompatible with the current version, ruby 3.1.0p-1
Error: Process completed with exit code 5.

@gauravtiwari
Copy link
Member

thanks @gencer will take a look and get this merged.

@n-rodriguez
Copy link
Contributor

ping @gauravtiwari it would be nice to merge this one

@n-rodriguez
Copy link
Contributor

ping @gauravtiwari

1 similar comment
@n-rodriguez
Copy link
Contributor

ping @gauravtiwari

@pedrofurtado
Copy link
Member

Hey, @gencer ! 👋

Thank you so much for your contribution!

Can you please rebase/sync your fork repo to master of webpacker? Recently, we fixed the CI/tests in master branch, so after rebase/sync, the test will be able to run again in your PR and (probably) will be all green 👍

After that, we'll be ready to merge ✅

CoffeeScript both included as a rule in `rules/` and also in `resolves` but its not processed with coffe. This also fixes rails#2845. See the comments of that issue for more details.
@gencer
Copy link
Contributor Author

gencer commented Feb 9, 2021

Hi @pedrofurtado

Rebased & pushed. All green now.

Thanks!

@pedrofurtado
Copy link
Member

Pinging @gauravtiwari @guillaumebriday. Tested, good fix (thanks again @gencer 🤝 !), ready for merge ✅

@guillaumebriday
Copy link
Member

LGTM

@gauravtiwari gauravtiwari merged commit a3c1d75 into rails:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpacker 6 and babel.config.js
5 participants