Skip to content

Fix vue loader #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 27, 2017
Merged

Fix vue loader #298

merged 5 commits into from
Apr 27, 2017

Conversation

gauravtiwari
Copy link
Member

@gauravtiwari gauravtiwari commented Apr 27, 2017

Fixes - #297

@gauravtiwari
Copy link
Member Author

@Davidzhu001 Could you please try this?

@Davidzhu001
Copy link
Contributor

chunk    {7} components/land_page/sheep.js, components/land_page/sheep.js.map (components/land_page/sheep) 302 kB [entry]

here is a interesting line. My sheep is a jpg file.
and style is not really loading.

And I tried to update gem to rails/webpacker since you merged your branch yesterday.

@gauravtiwari
Copy link
Member Author

Could you try this branch gauravtiwari:fix-vue-loader and you would need to run bundle exec rails webpacker:install:vue

@gauravtiwari
Copy link
Member Author

gauravtiwari commented Apr 27, 2017

Just tested it should work now 👍

@Davidzhu001
Copy link
Contributor

Davidzhu001 commented Apr 27, 2017

did you change a way of importing css from vue comp

@gauravtiwari
Copy link
Member Author

Nope, just added loaders. Any problem?

@Davidzhu001
Copy link
Contributor

maybe my project is messed up. it only loads script from the components.
Let me redo a new project to test it out.

@Davidzhu001
Copy link
Contributor

Ok, it worked.

@gauravtiwari
Copy link
Member Author

Great, thanks for confirming 🍰

@gauravtiwari gauravtiwari merged commit 6d7d3b8 into rails:master Apr 27, 2017
@gauravtiwari gauravtiwari deleted the fix-vue-loader branch April 27, 2017 17:01
@Davidzhu001
Copy link
Contributor

@gauravtiwari you are the best. Thanks for maintaining this gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants