Skip to content

Target current node version in .babelrc #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2017
Merged

Target current node version in .babelrc #362

merged 1 commit into from
May 10, 2017

Conversation

gauravtiwari
Copy link
Member

@gauravtiwari gauravtiwari commented May 10, 2017

@gauravtiwari gauravtiwari merged commit 42db6f7 into rails:master May 10, 2017
@gauravtiwari gauravtiwari deleted the fix-babelrc branch May 10, 2017 17:39
@RavenXce
Copy link
Contributor

I just realized .babelrc was updated here. This will break stuff as useBuiltIns requires babel-polyfill so we need to add it to the yarn setup.

See instructions here: https://github.com/babel/babel-preset-env#usebuiltins

I also think the default target should be something sane and safe like "browsers": "> 1%". Targeting the latest node version doesn't make sense in a front-end web context as the supported feature set between browsers and nodejs can vary quite a lot. Supporting 99% of browsers by default should just work™ for most users which I think is what we want here.

@gauravtiwari
Copy link
Member Author

@RavenXce Oops. Wanna make a quick PR please?

@RavenXce
Copy link
Contributor

Sure. Linking the other conversation here so we have some context: #306 (comment)

@gauravtiwari
Copy link
Member Author

Cool thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants