Skip to content

Use rake in readme. #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use rake in readme. #375

wants to merge 1 commit into from

Conversation

ktusznio
Copy link

Using ./bin/rails as documented is failing against a new rails 4.2.x application:

~ » rails -v
Rails 4.2.8

~ » rails new foo
...

~ » cd foo
~/foo » echo "gem 'webpacker', git: 'https://github.com/rails/webpacker.git'" >> Gemfile
~/foo » bundle
Fetching https://github.com/rails/webpacker.git
Fetching gem metadata from https://rubygems.org/...........
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Resolving dependencies...
Using rake 12.0.0
Using i18n 0.8.1
Using minitest 5.10.2
Using thread_safe 0.3.6
Using builder 3.2.3
Using erubis 2.7.0
Using mini_portile2 2.1.0
Using rack 1.6.6
Using mime-types-data 3.2016.0521
Using arel 6.0.4
Using debug_inspector 0.0.3
Using bundler 1.14.6
Using byebug 9.0.6
Using coffee-script-source 1.12.2
Using execjs 2.7.0
Using thor 0.19.4
Using concurrent-ruby 1.0.5
Using multi_json 1.12.1
Using json 1.8.6
Using rdoc 4.3.0
Using sass 3.4.23
Using tilt 2.0.7
Using sqlite3 1.3.13
Using turbolinks-source 5.0.3
Using tzinfo 1.2.3
Using nokogiri 1.7.1
Using rack-test 0.6.3
Using mime-types 3.1
Using binding_of_caller 0.7.2
Using coffee-script 2.4.1
Using uglifier 3.2.0
Using sprockets 3.7.1
Using sdoc 0.4.2
Using turbolinks 5.0.1
Using activesupport 4.2.8
Using loofah 2.0.3
Using mail 2.6.5
Using rails-deprecated_sanitizer 1.0.3
Using globalid 0.4.0
Using activemodel 4.2.8
Using jbuilder 2.6.3
Using spring 2.0.1
Using rails-html-sanitizer 1.0.3
Using rails-dom-testing 1.0.8
Using activejob 4.2.8
Using activerecord 4.2.8
Using actionview 4.2.8
Using actionpack 4.2.8
Using actionmailer 4.2.8
Using railties 4.2.8
Using sprockets-rails 3.2.0
Using coffee-rails 4.1.1
Using jquery-rails 4.3.1
Using webpacker 1.2 from https://github.com/rails/webpacker.git (at master@9d579e8)
Using rails 4.2.8
Using sass-rails 5.0.6
Using web-console 2.3.0
Bundle complete! 13 Gemfile dependencies, 57 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.

~/foo » ./bin/rails webpacker:install
Error: Command 'webpacker:install' not recognized
Did you mean: `$ rake webpacker:install` ?
...

~/foo » rake webpacker:install
Running via Spring preloader in process 66337
Copying webpack core config and loaders
      create  config/webpack
... snip ...
Webpacker successfully installed 🎉 🍰

~/foo » echo woohoo!
woohoo!

@ytbryan
Copy link
Contributor

ytbryan commented May 12, 2017

i think the documentation is written with Rails 5 in mind. And Rails 5 has "Exclusive use of rails CLI over Rake" See http://guides.rubyonrails.org/5_0_release_notes.html

@ytbryan
Copy link
Contributor

ytbryan commented May 12, 2017

Kamil, thanks for pointing this out.

@gauravtiwari Maybe for webpacker 2.0, we can encourage users to use rails 5? 😉

@gauravtiwari
Copy link
Member

@ktusznio Thanks, but lets address this more clearly in #372. Feel free to add any notes you would like to add in the comments there.

@ytbryan Since webpacker doesn't have a lot of Rails dependent code, think it could be refactored to support any Rails version or in fact any ruby app (have some plans) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants