Skip to content

Update .babelrc #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2017
Merged

Update .babelrc #382

merged 3 commits into from
May 13, 2017

Conversation

RavenXce
Copy link
Contributor

@RavenXce RavenXce commented May 13, 2017

Remove useBuiltIns as it is only needed when using babel-polyfill.
Target browsers which have >1% usage instead of nodejs as it is more relevant for our users.
Use uglify: true setting as we are using UglifyJS in production. (I will make a PR to switch to https://github.com/babel/babili separately after I've tried it)

Resolves #306 and #35 properly.

Remove `useBuiltIns` as it is only relevant for use with `babel-polyfill`.
Target browsers which have more than 1% usage instead of node.
Use `uglify: true` setting as we are using UglifyJS in production.
@gauravtiwari
Copy link
Member

gauravtiwari commented May 13, 2017

@RavenXce Lets keep useBuiltIns for polyfilling based on env. You would need to add babel-polyfill to template.rb.

@RavenXce
Copy link
Contributor Author

Yup. Okay, let me add the required stuff.

@gauravtiwari
Copy link
Member

@RavenXce Thanks looks good 👍 One last thing, may be reference this issue #306 in the changelog to document this change?

@gauravtiwari gauravtiwari merged commit 03bc799 into rails:master May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants